Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Apr 18, 2023

PR Summary

The default character being used doesn't render on macOS in either iTerm2 nor Terminal. Fix is to use a character that works in Windows Terminal and macOS (not tested on Linux).

PR Context

Fix #19533

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from daxian-dbw April 18, 2023 23:40
@ghost ghost assigned anmenaga Apr 18, 2023
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested in cloud shell and it works. Not exactly the same as a local Linux terminal, but it gives us some confidence.

@SteveL-MSFT SteveL-MSFT assigned daxian-dbw and unassigned anmenaga Apr 19, 2023
@daxian-dbw daxian-dbw merged commit 5e96ed3 into PowerShell:master Apr 19, 2023
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 19, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

🎉v7.4.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback presentation incorrectly assumes UTF-8 support will render all Unicode characters

3 participants