Skip to content

Change arrow used in Feedback suggestion to a more common unicode character - #19534

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:feedback-arrow
Apr 19, 2023
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
SteveL-MSFT:feedback-arrow

Conversation

@SteveL-MSFT

@SteveL-MSFT Steve Lee (SteveL-MSFT) commented Apr 18, 2023 •

Copy link
Copy Markdown
Member

PR Summary

The default character being used doesn't render on macOS in either iTerm2 nor Terminal. Fix is to use a character that works in Windows Terminal and macOS (not tested on Linux).

PR Context

Fix #19533

PR Checklist

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested in cloud shell and it works. Not exactly the same as a local Linux terminal, but it gives us some confidence.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 5e96ed3 into PowerShell:master Apr 19, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 19, 2023
@ghost

Copy link
Copy Markdown

🎉v7.4.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback presentation incorrectly assumes UTF-8 support will render all Unicode characters

3 participants