Skip to content

Support trigger registration in Feedback Provider #19525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 6 commits into from
Apr 19, 2023
Merged

Support trigger registration in Feedback Provider #19525

daxian-dbw merged 6 commits into from
Apr 19, 2023

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Apr 17, 2023

PR Summary

PR Context

Address #19372 and address #19364

  1. Allow a feedback provider to register the trigger for it to be called. The triggers are: Comment, Success, CommandNotFound, Error, and All. By default, a feedback provider will be triggered by CommandNotFound only.
  2. Some refactoring:
    • update the interface method to pass in more context information.
    • split the FeedbackHub.GetFeedback methods into multiple helper methods to reduce its complexity.

PR Checklist

@daxian-dbw
Copy link
Member Author

daxian-dbw commented Apr 17, 2023 •
edited
Loading

It's helpful to ignore the whitespace changes during the review: https://github.com/PowerShell/PowerShell/pull/19525/files?w=1

@daxian-dbw daxian-dbw marked this pull request as ready for review April 18, 2023 00:47
@daxian-dbw daxian-dbw self-assigned this Apr 18, 2023
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 18, 2023
SteveL-MSFT
SteveL-MSFT approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will defer feedback until I can build a Feedback provider using the new triggers

@daxian-dbw daxian-dbw merged commit 457606a into PowerShell:master Apr 19, 2023
@daxian-dbw daxian-dbw deleted the feedback branch April 19, 2023 00:15
@ghost
Copy link

ghost commented Apr 20, 2023

🎉v7.4.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

@StevenBucher98 StevenBucher98 mentioned this pull request May 15, 2023
Closed
@JustinGrote
Copy link
Contributor

JustinGrote commented Oct 27, 2023

@daxian-dbw sorry to be late to the party on this, but I don't think the feedback trigger should have a default, it should be explicitly implemented. This bit me when writing a provider because when I used my IDE to implement the interface, it didn't pull this in and I couldn't figure out why it wasn't working. Since it is RC it may be too late since this would be breaking for existing feedback providers that haven't explicitly stated it, but just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

Assignees

@daxian-dbw daxian-dbw

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daxian-dbw @JustinGrote @SteveL-MSFT