Skip to content

Force update Microsoft.CSharp transitive dependency - #19514

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
TravisEz13:fix-pwsh-deps
Apr 18, 2023
Merged

Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
TravisEz13:fix-pwsh-deps

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Apr 14, 2023 •

Copy link
Copy Markdown
Member

PR Summary

  • Force update Microsoft.CSharp transitive dependency
    • NJsonSchema uses Namotion.Reflection, which uses Microsoft.CSharp 4.3.0 which has a security issue
    • The SDK automatically upgrades this, but some security scanners cannot tell because the assets.json and deps.json doesn't show evidence of this upgrading behavior.
    • Forcing the upgrade, so that assets.json and deps.json show 4.7.0, which is sufficient for the vulnerability scanning to work correctly.
  • CGManifest looks simpler because we are reading the same data that the scanners are using and now that we only ask for what the SDK has, it does not add the packages to the manifest.

PR Context

This was done is 7.2: 28514a7
This was done in 7.3: af8d716

PR Checklist

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit e05a097 into PowerShell:master Apr 18, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 19, 2023
@ghost

Copy link
Copy Markdown

🎉v7.4.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants