Skip to content

Fix dynamic parameter completion - #19510

Merged
Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
MartinGC94:FixDynamicParamCompletion
Aug 1, 2023
Merged

Dongbo Wang (daxian-dbw) merged 4 commits into
PowerShell:masterfrom
MartinGC94:FixDynamicParamCompletion

Conversation

@MartinGC94

Copy link
Copy Markdown
Contributor

PR Summary

Fixes the following scenario:

cd function::
Get-ChildItem C:\ -Fi<Tab>

Where tab completion wouldn't show the filesystem provider dynamic parameters, such as "-File".
The reason for this is that it tries to bind the parameters typed so far, including the partially typed parameter which wouldn't work. A check has been added so the parameter at the cursor is skipped for commands with dynamic parameters.

PR Context

Fixes #19498

PR Checklist

@ghost ghost assigned Ilya (iSazonov) Apr 14, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Apr 22, 2023
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw Dongbo Wang (daxian-dbw) added WG-Engine core PowerShell engine, interpreter, and runtime Needs-Triage The issue is new and needs to be triaged by a work group. labels May 1, 2023
@StevenBucher98 Steven Bucher (StevenBucher98) added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label May 8, 2023
@IISResetMe Mathias R. Jessen (IISResetMe) removed WG-Engine core PowerShell engine, interpreter, and runtime Needs-Triage The issue is new and needs to be triaged by a work group. labels May 15, 2023
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 22 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +19 -3
Percentile : 8.8%

Total files changed: 3

Change summary by file extension:
.cs : +11 -3
.ps1 : +8 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 0502da7 into PowerShell:master Aug 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Aug 1, 2023
@daxian-dbw Dongbo Wang (daxian-dbw) added Review - Needed The PR is being reviewed CL-Engine Indicates that a PR should be marked as an engine change in the Change Log labels Aug 1, 2023
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Small PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update Review - Needed The PR is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tab-completion doesn't honor the provider context provided by a previous argument when surfacing dynamic parameters

6 participants