Skip to content

Add specific error message that creating Junctions requires absolute path #19409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulHigin merged 1 commit into from
May 9, 2023
Merged

Add specific error message that creating Junctions requires absolute path #19409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/System.Management.Automation/namespaces/FileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2434,6 +2434,13 @@ protected override void NewItem(

bool exists = false;

// junctions require an absolute path
if (!Path.IsPathRooted(strTargetPath))
{
WriteError(new ErrorRecord(new ArgumentException(FileSystemProviderStrings.JunctionAbsolutePath), "NotAbsolutePath", ErrorCategory.InvalidArgument, strTargetPath));
return;
}

try
{
exists = GetFileSystemInfo(strTargetPath, out isDirectory) != null;
Expand Down
3 changes: 3 additions & 0 deletions src/System.Management.Automation/resources/FileSystemProviderStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,4 +345,7 @@
<data name="CopyingLocalBytesStatus" xml:space="preserve">
<value>{0} of {1} ({2:0.0} MB/s)</value>
</data>
<data name="JunctionAbsolutePath" xml:space="preserve">
<value>Creating a junction requires an absolute path for the target.</value>
</data>
</root>
11 changes: 11 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,17 @@ Describe "Hard link and symbolic link tests" -Tags "CI", "RequireAdminOnWindows"
Test-Path $junctionToDir | Should -BeTrue
}

It 'New-Item fails creating junction with relative path' -Skip:(!$IsWindows) {
try {
Push-Location $TestDrive
1 > 1.txt
{ New-Item -ItemType Junction -Path 2.txt -Target 1.txt -ErrorAction Stop } | Should -Throw -ErrorId "NotAbsolutePath,Microsoft.PowerShell.Commands.NewItemCommand"
}
finally {
Pop-Location
}
}

It 'New-Item can create hardlink with relative path' {
try {
Push-Location $TestDrive
Expand Down