-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add comment in wix detailing use of UseMU
#19371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment in wix detailing use of UseMU
#19371
Conversation
|
Thanks for the quick fix @SteveL-MSFT - if I'd known it was that simple I'd have submitted the PR myself! |
|
@kilasuit just need @TravisEz13 to say if this was deliberately missing previously or not |
UseMU reg value on uninstall of MSIUseMU
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
🎉 Handy links: |
PR Summary
UseMUis for both stable and preview versions only to determine if Microsoft Updates should be for the INSTALLED version. So if neither stable nor preview is installed, then this reg value takes no effect. Not removing it during uninstall is deliberate and this PR adds a comment explaining this.PR Context
Related #19356
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).