Skip to content

Conversation

@CarloToso
Copy link
Contributor

@CarloToso CarloToso commented Feb 26, 2023

PR Summary

  • Currently we only check for -ContentType and we ignore -Headers @{Content-Type=...} after this PR we also check for ContentType in headers

  • If we set both -ContentType and -Headers @{Content-Type=...} --> -ContentType is used

We will also have to change the documentation that documents this behaviour

PR Context

Fixes #19156

PR Checklist

@pull-request-quantifier-deprecated

This PR has 19 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +15 -4
Percentile : 7.6%

Total files changed: 2

Change summary by file extension:
.cs : +4 -3
.ps1 : +11 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Documentation Needed in this repo Documentation is needed in this repo labels Mar 1, 2023
@iSazonov
Copy link
Collaborator

iSazonov commented Mar 1, 2023

@CarloToso Please open new doc issue and add reference in the PR description.

@iSazonov iSazonov changed the title WebCmdlets check for ContentType in Headers Take into account ContentType from Headers in WebCmdlets Mar 1, 2023
@iSazonov iSazonov merged commit cf622f8 into PowerShell:master Mar 1, 2023
@iSazonov iSazonov assigned iSazonov and unassigned PaulHigin Mar 1, 2023
@CarloToso CarloToso deleted the Webcmdlets-use-content-type-in-headers branch March 1, 2023 18:23
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate possible BUG Invoke-WebRequest content type charset

3 participants