-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Replace BitConverter.ToString(bytes).Replace("-", "") with Convert.ToHexString(bytes) #19216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@turbedi I found one more string payLoadData = Convert.ToHexString(fragmentData.blob, fragmentData.offset, fragmentData.length);
payLoadData = string.Create(CultureInfo.InvariantCulture, $"0x{payLoadData}");
|
Co-Authored-By: CarloToso <105941898+CarloToso@users.noreply.github.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Good catch, fixed.
|
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 Handy links: |
PR Summary
Replace BitConverter.ToString(bytes).Replace("-", "") with Convert.ToHexString(bytes) which is more performant and saves allocations.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).