Skip to content

Replace Requires.Condition with ArgumentOutOfRangeException.ThrowIfNegativeOrZero #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Feb 23, 2023
Merged

Replace Requires.Condition with ArgumentOutOfRangeException.ThrowIfNegativeOrZero #19201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/Subsystem/FeedbackSubsystem/FeedbackHub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public static class FeedbackHub
/// </summary>
public static List<FeedbackResult>? GetFeedback(Runspace runspace, int millisecondsTimeout)
{
Requires.Condition(millisecondsTimeout > 0, nameof(millisecondsTimeout));
ArgumentOutOfRangeException.ThrowIfNegativeOrZero(millisecondsTimeout);

var localRunspace = runspace as LocalRunspace;
if (localRunspace is null)
Expand Down
2 changes: 1 addition & 1 deletion src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/CommandPrediction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static class CommandPrediction
/// <returns>A list of <see cref="PredictionResult"/> objects.</returns>
public static async Task<List<PredictionResult>?> PredictInputAsync(PredictionClient client, Ast ast, Token[] astTokens, int millisecondsTimeout)
{
Requires.Condition(millisecondsTimeout > 0, nameof(millisecondsTimeout));
ArgumentOutOfRangeException.ThrowIfNegativeOrZero(millisecondsTimeout);

var predictors = SubsystemManager.GetSubsystems<ICommandPredictor>();
if (predictors.Count == 0)
Expand Down
8 changes: 0 additions & 8 deletions src/System.Management.Automation/engine/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1748,13 +1748,5 @@ internal static void NotNullOrEmpty(ICollection value, string paramName)
throw new ArgumentNullException(paramName);
}
}

internal static void Condition([DoesNotReturnIf(false)] bool precondition, string paramName)
{
if (!precondition)
{
throw new ArgumentException(paramName);
}
}
}
}