Skip to content

Infer external application output as strings #19193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 4 commits into from
Mar 14, 2023
Merged

Infer external application output as strings #19193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
567260b
Infer external application output as strings
MartinGC94 Feb 22, 2023
afc2eea
Merge branch 'PowerShell:master' into InferExternalAppsAsStrings
MartinGC94 Feb 24, 2023
6d147ad
Apply suggestions from code review
MartinGC94 Mar 14, 2023
9b7394a
Remove unnecessary check. Add check for null command names. Fix typo.
MartinGC94 Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion src/System.Management.Automation/engine/parser/TypeInferenceVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,8 +1021,32 @@ private void InferTypesFrom(CommandAst commandAst, List<PSTypeName> inferredType
PseudoBindingInfo pseudoBinding = new PseudoParameterBinder()
.DoPseudoParameterBinding(commandAst, null, null, PseudoParameterBinder.BindingType.ParameterCompletion);

if (pseudoBinding?.CommandInfo == null)
if (pseudoBinding?.CommandInfo is null)
{
var commandName = commandAst.GetCommandName();
if (string.IsNullOrEmpty(commandName))
{
return;
}

try
{
var foundCommand = CommandDiscovery.LookupCommandInfo(
commandName,
CommandTypes.Application,
SearchResolutionOptions.ResolveLiteralThenPathPatterns,
CommandOrigin.Internal,
_context.ExecutionContext);

// There's no way to know whether or not an application outputs anything
// but when they do, PowerShell will treat it as string data.
inferredTypes.Add(new PSTypeName(typeof(string)));
}
catch
{
// The command wasn't found so we can't infer anything.
}

return;
}

Expand Down
5 changes: 5 additions & 0 deletions test/powershell/engine/Api/TypeInference.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,6 +1383,11 @@ Describe "Type inference Tests" -tags "CI" {
$res.Count | Should -Be 1
$res.Name | Should -Be 'System.Management.Automation.Internal.Host.InternalHost'
}

It 'Infers type of external applications' {
$res = [AstTypeInference]::InferTypeOf( { pwsh }.Ast)
$res.Name | Should -Be 'System.String'
}
}

Describe "AstTypeInference tests" -Tags CI {
Expand Down