-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Added minor readability and refactoring fixes to Process.cs #19123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added minor readability and refactoring fixes to Process.cs #19123
Conversation
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Outdated
Show resolved
Hide resolved
…nt/Process.cs Co-authored-by: Ilya <darpa@yandex.ru>
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
Outdated
Show resolved
Hide resolved
…nt/Process.cs Co-authored-by: Ilya <darpa@yandex.ru>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
PR Summary
Added the following readability fixes to
Process.cs:_includeUserNameprivate member as its not used. Any checking with this switch parameter usesIncludeUserName.IsPresent.ifstatements on new lines, makes it easier to read.switchandcaseinto expression.DWORDandFileNakedHandlealias directives.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).