Skip to content

Dispose previous response in Webcmdlets #19117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Feb 9, 2023
Merged

Dispose previous response in Webcmdlets #19117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e66e7c8
using response; response.Dispose()
CarloToso Feb 8, 2023
1c6c73c
Merge branch 'master' into investigation-on-disposing-of-HttpResponse…
CarloToso Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,7 @@ internal virtual HttpResponseMessage GetResponse(HttpClient client, HttpRequestM

// Continue to handle redirection
using HttpRequestMessage redirectRequest = GetRequest(currentUri);
response.Dispose();
response = GetResponse(client, redirectRequest, handleRedirect);
}

Expand Down Expand Up @@ -1306,7 +1307,8 @@ internal virtual HttpResponseMessage GetResponse(HttpClient client, HttpRequestM

WriteVerbose(reqVerboseMsg);

return GetResponse(client, requestWithoutRange, handleRedirect);
response.Dispose();
response = GetResponse(client, requestWithoutRange, handleRedirect);
}
}

Expand Down Expand Up @@ -1419,7 +1421,7 @@ protected override void ProcessRecord()

WriteVerbose(reqVerboseMsg);

HttpResponseMessage response = GetResponse(client, request, handleRedirect);
using HttpResponseMessage response = GetResponse(client, request, handleRedirect);

string contentType = ContentHelper.GetContentType(response);
string respVerboseMsg = string.Format(
Expand Down