-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix redirection for -CustomMethod "POST" in WebCmdlets #19111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redirection for -CustomMethod "POST" in WebCmdlets #19111
Conversation
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Show resolved
Hide resolved
iSazonov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Could you please check that new tests don't work with 7.3?
|
@iSazonov I confirm the new test fails in PS7.3.2 |
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Outdated
Show resolved
Hide resolved
|
@CarloToso Please resolve merge conflict. |
|
Resolved merge conflict |
|
Unrelated error |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
PR Summary
If we get to this point with -CustomMethod "POST", we don't use
IsRedirectToGetbecause we only check forMethod == WebRequestMethod.Post--> checking for
req.Method == HttpMethod.Postsolves this but:setting
Method = WebRequestMethod.Getwould be ignored byHttpMethod httpMethod = string.IsNullOrEmpty(CustomMethod) ? GetHttpMethod(Method) : new HttpMethod(CustomMethod)(inGetResponseline 1230)--> solved by setting CustomMethod = string.Empty
PR Context
Fix bug discussed in #18894 @iSazonov, merge before #18894
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).