Skip to content

Ignore expected error for file systems not supporting alternate streams #19065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulHigin merged 1 commit into from
Jan 31, 2023
Merged

Ignore expected error for file systems not supporting alternate streams #19065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/System.Management.Automation/namespaces/FileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8098,7 +8098,10 @@ internal static List<AlternateStreamData> GetStreams(string path)

// Directories don't normally have alternate streams, so this is not an exceptional state.
// If a directory has no alternate data streams, FindFirstStreamW returns ERROR_HANDLE_EOF.
if (error == NativeMethods.ERROR_HANDLE_EOF)
// If the file system (such as FAT32) does not support alternate streams, then
// ERROR_INVALID_PARAMETER is returned by FindFirstStreamW. See documentation:
// https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-findfirststreamw
if (error == NativeMethods.ERROR_HANDLE_EOF || error == NativeMethods.ERROR_INVALID_PARAMETER)
{
return alternateStreams;
}
Expand Down Expand Up @@ -8135,7 +8138,9 @@ internal static List<AlternateStreamData> GetStreams(string path)

int lastError = Marshal.GetLastWin32Error();
if (lastError != NativeMethods.ERROR_HANDLE_EOF)
{
throw new Win32Exception(lastError);
}
}
finally { handle.Dispose(); }

Expand Down