Repository navigation
Hotfix/nuget packages - #19033
Hotfix/nuget packages#19033Darren Kattan (dkattan) wants to merge 2 commits into
Conversation
… how to test as DevOps relies on items I don't have access to.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Travis Plunk (@TravisEz13) Can you take a look at this and let me know what you think? |
|
Aditya Patwardhan (@adityapatwardhan) Can you review? |
| PackageVersion = $Version | ||
| PackageRuntime = $Runtime | ||
| PackageConfiguration = $Configuration | ||
| IncludeSymbols = $IncludeSymbols |
There was a problem hiding this comment.
Revert this. This is just a test file.
There was a problem hiding this comment.
But shouldn't we also test this?
There was a problem hiding this comment.
This is used only for testing the compiler. Please remove this.
|
I have some concerns about the size of the nuget packages with symbols added in. I am starting a private build for the change to see if it fixes it. My hunch is that it would need some code to be added here: PowerShell/tools/packaging/packaging.psm1 Lines 2542 to 2624 in c87f2a4 |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Closing this PR as Aditya Patwardhan (@adityapatwardhan) is actively working on a solution to this issue. |
PR Summary
Should fix #16862
Microsoft.PowerShell.SDK is missing references to
This was OK because you could manually specify the a Reference via a HintPath but this workaround broke in 7.2 preview 7 due to this change: 046dec4#r98046816
Since then, it is literally impossible to reference types in any of those 4 libraries like ResolvePathCommand among dozens of others.
The only way I was able to work around this was by using a hex editor to modify the Microsoft.PowerShell.Commands.Management.DLL file to reference System.Management.Automation 7.X.X.0 instead of 7.X.X.500
Additionally, added symbols to the nuget packages so SourceLink could work which will help app developers using the PowerShell SDK tremendously.
This change should not have any negative consequences as the nuget packages are unusable anyway, however I don't have a great way to test this as the devops pipeline only works in the Microsoft DevOps environment.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).