Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Jan 24, 2023

PR Summary

This PR corrects an issue with multiple modules loaded in a session and having functions with the same name. Previously all functions with that name become public even if only one module makes the function public.

PR Context

PowerShell's function list does not distinguish between session functions and module functions, and also does not allow duplicate function names. This caused some private module functions to be made publicly accessible. The fix is to update module function accessibility code to account for potential duplicate function names.

PR Checklist

@pull-request-quantifier-deprecated

This PR has 147 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Medium
Size       : +96 -51
Percentile : 49.4%

Total files changed: 3

Change summary by file extension:
.cs : +96 -51

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost assigned daxian-dbw Jan 24, 2023
@daxian-dbw daxian-dbw assigned TravisEz13 and unassigned daxian-dbw Jan 24, 2023
@TravisEz13
Copy link
Member Author

TravisEz13 commented Jan 31, 2023

Test failure unrelated to change:

It failed in two unrelated runs:

@TravisEz13

This comment was marked as duplicate.

@TravisEz13 TravisEz13 enabled auto-merge (squash) February 2, 2023 00:06
@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 2, 2023
@TravisEz13 TravisEz13 merged commit 137b4d7 into PowerShell:master Feb 2, 2023
@TravisEz13 TravisEz13 deleted the JEA branch February 2, 2023 00:21
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants