Skip to content

Use interpolated strings 11 #19002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 6 commits into from
Jan 23, 2023
Merged

Use interpolated strings 11 #19002

iSazonov merged 6 commits into from
Jan 23, 2023

Conversation

@CarloToso
Copy link
Contributor

@CarloToso CarloToso commented Jan 21, 2023 •
edited by iSazonov
Loading

PR Summary

Replace string.Format() with new string.Create((IFormatProvider? provider, [InterpolatedStringHandlerArgument(nameof(provider))] ref DefaultInterpolatedStringHandler handler).

PR Context

#18974

PR Checklist

@ghost ghost assigned TravisEz13 Jan 21, 2023
iSazonov
iSazonov reviewed Jan 21, 2023
View reviewed changes
@iSazonov iSazonov added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Jan 22, 2023
iSazonov
iSazonov reviewed Jan 22, 2023
View reviewed changes
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Jan 22, 2023

This PR has 106 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Medium
Size       : +21 -85
Percentile : 41.2%

Total files changed: 14

Change summary by file extension:
.cs : +21 -85

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Jan 23, 2023
@iSazonov iSazonov merged commit 4c586a7 into PowerShell:master Jan 23, 2023
@iSazonov
Copy link
Collaborator

iSazonov commented Jan 23, 2023

@CarloToso You seem to have updated everything possible?

@CarloToso CarloToso deleted the Use-interpolated-strings-11 branch January 23, 2023 17:37
@CarloToso
Copy link
Contributor Author

CarloToso commented Jan 23, 2023

@iSazonov I think so, this was my regex search query in vscode: string\.Format.*\{0\}|string\.Create.*\{0\}|\.Append.*\{0\}|\.AppendFormat.*\{0\}|string\.Format.*\n.*\{0\}|string\.Create.*\n.*\{0\}|\.Append.*\n.*\{0\}|\.AppendFormat.*\n.*\{0\}

@iSazonov
Copy link
Collaborator

iSazonov commented Jan 23, 2023

@CarloToso Many thanks!

@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CarloToso @iSazonov @SteveL-MSFT @TravisEz13