Skip to content

Fix Get-Error to work with strict mode #18895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 2 commits into from
Jan 13, 2023
Merged

Fix Get-Error to work with strict mode #18895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b35bbb7
Fix `Get-Error` to work with strict mode
SteveL-MSFT Jan 6, 2023
cef101c
remove extra whitespace
SteveL-MSFT Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...m.Management.Automation/FormatAndOutput/DefaultFormatters/PowerShellCore_format_ps1xml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,10 +1016,11 @@ private static IEnumerable<FormatViewDefinition> ViewsOf_System_Management_Autom
CustomControl.Create(outOfBand: true)
.StartEntry()
.AddScriptBlockExpressionBinding(@"
$errorColor = ''
$commandPrefix = ''
if (@('NativeCommandErrorMessage','NativeCommandError') -notcontains $_.FullyQualifiedErrorId -and @('CategoryView','ConciseView','DetailedView') -notcontains $ErrorView)
{
$myinv = $_.InvocationInfo
$errorColor = ''
if ($Host.UI.SupportsVirtualTerminal) {
$errorColor = $PSStyle.Formatting.Error
}
Expand Down Expand Up @@ -1070,10 +1071,7 @@ private static IEnumerable<FormatViewDefinition> ViewsOf_System_Management_Autom
}
}

if ($commandPrefix)
{
$errorColor + $commandPrefix
}
$errorColor + $commandPrefix
")
.AddScriptBlockExpressionBinding(@"
Set-StrictMode -Off
Expand Down
5 changes: 5 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Error.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,4 +145,9 @@ Describe 'Get-Error tests' -Tag CI {
}
}
}

It 'Get-Error works with strict mode' {
$out = pwsh -noprofile -command 'Set-StrictMode -Version Latest; $PSStyle.OutputRendering = "PlainText"; 1/0; Get-Error' | Out-String
$out | Should -Match "Message : Attempted to divide by zero."
}
}