-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add -ProgressAction common parameter
#18887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
iSazonov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment.
src/System.Management.Automation/engine/CommonCommandParameters.cs
Outdated
Show resolved
Hide resolved
…s.cs Co-authored-by: Paul Higinbotham <paulhi@microsoft.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
PR Summary
Per @PowerShell/wg-powershell-cmdlets review, we should have a
-ProgressActioncommon parameter which we believe is a bucket 3 breaking change.PR Context
Fix #18737
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.-ProgressActionparameter MicrosoftDocs/PowerShell-Docs#9658(which runs in a different PS Host).