Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Jan 3, 2023

PR Summary

Catch DLL not found exception during static init and record the failure.

PR Context

Nanoserver doesn't have AMSI, so, we have to handle that case.

Fixed break caused by: 36282c2
ie #18727

PR Checklist

@pull-request-quantifier-deprecated

This PR has 7 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +6 -1
Percentile : 2.8%

Total files changed: 1

Change summary by file extension:
.cs : +6 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost assigned PaulHigin Jan 3, 2023
@TravisEz13 TravisEz13 changed the title Fix support for nanoserver due to lack of AMSI Handle AMSI initialization failures Jan 3, 2023
Copy link
Contributor

@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13
Copy link
Member Author

/azp run powershell-ci-linux

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@suajose
Copy link
Contributor

suajose commented Jan 3, 2023

looks good

@TravisEz13 TravisEz13 marked this pull request as ready for review January 4, 2023 17:56
@TravisEz13 TravisEz13 merged commit a1fd61d into master Jan 4, 2023
@TravisEz13 TravisEz13 deleted the TravisEz13-patch-amsi-nano branch January 4, 2023 17:57
@TravisEz13 TravisEz13 added Backport-5.1-Consider Consider to backport to Windows PowerShell 5.1 due to impact Backport-7.3.x-Consider labels Jan 4, 2023
@adityapatwardhan
Copy link
Member

Maintainers discussed this for backport and recommend having more bake time in preview release before backporting.

@adityapatwardhan adityapatwardhan added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Mar 14, 2023
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 13, 2023

🎉v7.3.4 has been released which incorporates this pull request.:tada:

Handy links:

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-5.1-Consider Consider to backport to Windows PowerShell 5.1 due to impact Backport-7.3.x-Done CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants