-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Handle AMSI initialization failures #18882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
PaulHigin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/azp run powershell-ci-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
looks good |
|
Maintainers discussed this for backport and recommend having more bake time in preview release before backporting. |
|
🎉 Handy links: |
|
🎉 Handy links: |
PR Summary
Catch DLL not found exception during static init and record the failure.
PR Context
Nanoserver doesn't have AMSI, so, we have to handle that case.
Fixed break caused by: 36282c2
ie #18727
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).