Skip to content

Fix Format-Table -RepeatHeader for property derived tables #18870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Dec 31, 2022
Merged

Fix Format-Table -RepeatHeader for property derived tables #18870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/System.Management.Automation/FormatAndOutput/common/FormatViewGenerator_Table.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ private TableHeaderInfo GenerateTableHeaderInfoFromProperties(PSObject so)
TableHeaderInfo thi = new TableHeaderInfo();

thi.hideHeader = this.HideHeaders;
thi.repeatHeader = this.RepeatHeader;

for (int k = 0; k < this.activeAssociationList.Count; k++)
{
Expand Down
8 changes: 8 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Format-Table.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,14 @@ A Name B
($lines | Select-String "Name\s*Value").Count | Should -Be ($numHeaders + 1)
}

It "-RepeatHeader should output the header at every screen full for custom table" -Skip:([Console]::WindowHeight -eq 0) {
$numHeaders = 4
$numObjects = [Console]::WindowHeight * $numHeaders
$out = 1..$numObjects | ForEach-Object { [pscustomobject]@{foo=$_;bar=$_;hello=$_;world=$_} } | Format-Table -Property hello, world -RepeatHeader | Out-String
$lines = $out.Split([System.Environment]::NewLine)
($lines | Select-String "Hello\s*World").Count | Should -Be ($numHeaders + 1)
}

It "Should be formatted correctly if width is declared and using center alignment" {
$expectedTable = @"

Expand Down