-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update build to include WinForms/WPF in all Windows builds #18859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
🎉 Handy links: |
PR Summary
build.psm1had logic prior to PS7 supporting win-arm64 that checks if the runtime starts withwin7-*, however, arm64 runtime iswin-arm64so it gets excluded. There's two parts as one is for restore and one is for publish. Since we currently still buildwin-arm(although not supported) and it's a much bigger change to remove that, the fix is to special casewin-arm64runtime.Manually validated the assemblies are there and
out-gridviewworks on arm64.PR Context
Fix #18858
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).