Skip to content

Allow combining of -Skip and -SkipLast parameters in Select-Object cmdlet. #18849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 4 commits into from
May 2, 2023
Merged

Allow combining of -Skip and -SkipLast parameters in Select-Object cmdlet. #18849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f83da3
Added SkipLast parameter set to Skip parameter and updated tests
ArmaanMcleod Dec 26, 2022
0266e78
Using Should -BeExactly with string
ArmaanMcleod Dec 26, 2022
8dada6d
Update test/powershell/Modules/Microsoft.PowerShell.Utility/Select-Ob…
TravisEz13 May 1, 2023
8c2e690
Merge remote-tracking branch 'upstream/master' into select-object-ski…
TravisEz13 May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/Select-Object.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,11 @@ public int First
private bool _firstOrLastSpecified;

/// <summary>
/// Skips the specified number of items from top when used with First, from end when used with Last.
/// Skips the specified number of items from top when used with First, from end when used with Last or SkipLast.
/// </summary>
/// <value></value>
[Parameter(ParameterSetName = "DefaultParameter")]
[Parameter(ParameterSetName = "SkipLastParameter")]
[ValidateRange(0, int.MaxValue)]
public int Skip { get; set; }

Expand Down
23 changes: 23 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Select-Object.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,29 @@ Describe "Select-Object DRT basic functionality" -Tags "CI" {
$results[1] | Should -Be 3
}

It "Select-Object with SkipLast should work" {
$results = "1", "2", "3" | Select-Object -SkipLast 1
$results.Count | Should -Be 2
$results[0] | Should -BeExactly "1"
$results[1] | Should -BeExactly "2"
}

It "Select-Object with Skip and SkipLast should work" {
$results = "1", "2", "3" | Select-Object -Skip 1 -SkipLast 1
$results.Count | Should -Be 1
$results[0] | Should -BeExactly "2"
}

It "Select-Object with Skip and SkipLast should work with Skip overlapping SkipLast" {
$results = "1", "2" | Select-Object -Skip 2 -SkipLast 1
$results. Count | Should -Be 0
}

It "Select-Object with Skip and SkipLast should work with skiplast overlapping skip" {
$results = "1", "2" | Select-Object -Skip 1 -SkipLast 2
$results. Count | Should -Be 0
}

It "Select-Object with Index should work" {
$results = "1", "2", "3" | Select-Object -Index 2
$results.Count | Should -Be 1
Expand Down