-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Improve Invoke-WebRequest xml and json errors format #18837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iSazonov
merged 31 commits into
PowerShell:master
from
CarloToso:Invoke-WebRequest-fix-xml-error
Feb 9, 2023
+87
−4
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
84152a5
beginning
CarloToso c36b8e2
Better Xml Error
CarloToso 4401247
remove extra space
CarloToso 408248e
Add two alternatives for settings.encoding
CarloToso dc17e16
fix error
CarloToso b6ecfd5
e -> E
CarloToso a0157f8
FormatErrorMessage; add jsonerror
CarloToso fa867ef
remove empty line
CarloToso e3305db
fix codefactor
CarloToso 20467ea
fix errors
CarloToso 85e76c8
add new line at the beginning of xml and json errors
CarloToso a44d17a
add newline to html error; remove regex html xml
CarloToso 1e4dca9
;
CarloToso 0db9ca4
remove newline (broke tests)
CarloToso 70a776a
move FormatErrorMessage in Helper Methods
CarloToso cc37269
Revert to old behaviour for plain text and html
CarloToso bf3d007
fix error try-catch
CarloToso a2482cd
remove tabs
CarloToso ce5ca66
Add back NewLines
CarloToso d0f88d4
add tests for xml and json errors
CarloToso 28d8152
spacing
CarloToso f2992b3
spaces
CarloToso 7618c2b
fix?
CarloToso 7edeedb
fix param
CarloToso a5ccbfe
different newline if windows
CarloToso b3065c1
Merge branch 'master' into Invoke-WebRequest-fix-xml-error
CarloToso cc5a5c5
small changes Xml error
CarloToso 7b04f41
ewmoved encoding the default is already UTF8
CarloToso c7ff97c
follow suggestions
CarloToso 586583a
remove bool converted
CarloToso f2a2113
remove String.Length > 0
CarloToso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.