Skip to content

Requires.NotNull-->ArgumentNullException.ThrowIfNull #18820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 7 commits into from
Jan 7, 2023
Merged

Requires.NotNull-->ArgumentNullException.ThrowIfNull #18820

iSazonov merged 7 commits into from
Jan 7, 2023

Conversation

@CarloToso
Copy link
Contributor

@CarloToso CarloToso commented Dec 18, 2022 •
edited by daxian-dbw
Loading

PR Summary

Replace all NotNull with ArgumentNullException.ThrowIfNull excluding ComInterop code

PR Context

As discussed in #18792

The new API ArgumentNullException.ThrowIfNull allows you to omit the parameter name, in which case it will use the name of the argument passed in. The passed in argument usually is the parameter to be validated, so that's just the right name to use when calling ArgumentNullException.ThrowIfNull(argument).

@ghost ghost assigned PaulHigin Dec 18, 2022
iSazonov
iSazonov reviewed Dec 19, 2022
View reviewed changes
src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/CommandPrediction.cs Outdated
public static void OnCommandLineAccepted(PredictionClient client, IReadOnlyList<string> history)
{
Requires.NotNull(history, nameof(history));
ArgumentNullException.ThrowIfNull(history, nameof(history));
Copy link
Collaborator

@iSazonov iSazonov Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have second argument. Below too.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 19, 2022
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 27, 2022
@ghost
Copy link

ghost commented Dec 27, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

xtqqczze
xtqqczze approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@xtqqczze xtqqczze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iSazonov
iSazonov reviewed Jan 7, 2023
View reviewed changes
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Jan 7, 2023

This PR has 12 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +6 -6
Percentile : 4.8%

Total files changed: 3

Change summary by file extension:
.cs : +6 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov assigned iSazonov and unassigned PaulHigin Jan 7, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 7, 2023
@iSazonov iSazonov merged commit 0788669 into PowerShell:master Jan 7, 2023
@CarloToso CarloToso deleted the Requires.NotNull-->ArgumentNullException.ThrowIfNull branch January 7, 2023 15:59
daxian-dbw added a commit that referenced this pull request Feb 14, 2023
@daxian-dbw
Revert " Requires.NotNull-->ArgumentNullException.ThrowIfNull (#18820)"
ebf4d1a 
This reverts commit 0788669.
This was referenced Feb 14, 2023
Closed
Closed
Merged
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@xtqqczze xtqqczze xtqqczze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CarloToso @iSazonov @xtqqczze @PaulHigin