Skip to content

Conversation

@CarloToso
Copy link
Contributor

@CarloToso CarloToso commented Dec 8, 2022

PR Summary

This PR adds a regex to get the charset from the XML declaration.

PR Context

After this PR I think we can close #3267, the current release already parses the HTML meta charset attribute.

Implements part of the logic proposed by @mklement0 in #11547
#11547 (comment)

Test: InvokeWeb-Request "https://fossies.org/linux/www/mnogosearch-3.4.1.tar.gz/mnogosearch-3.4.1/msearch-test/test-parsexml/htdocs/cp1251.xml?m=t"
(tested on a random windows-1251 xml I found online)

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 9, 2022
@iSazonov iSazonov requested a review from TravisEz13 December 9, 2022 09:47
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 20, 2022
@ghost
Copy link

ghost commented Dec 20, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@pull-request-quantifier-deprecated

This PR has 32 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +19 -13
Percentile : 12.8%

Total files changed: 1

Change summary by file extension:
.cs : +19 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 21, 2023
@iSazonov iSazonov merged commit 099cbc1 into PowerShell:master Jan 21, 2023
@CarloToso CarloToso deleted the xmlregex-streamhelper branch January 21, 2023 17:28
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webcmdlets should parse the <html><head><meta charset="foo"> attribute for the correct encoding if not in http header

4 participants