Skip to content

[backport release/v7.3.2] Fix Switch-Process error to include the command that is not found #18650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 2 commits into from
Jan 4, 2023
Merged

[backport release/v7.3.2] Fix Switch-Process error to include the command that is not found #18650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be61593
Fix `Switch-Process` error to include the command that is not found (…
SteveL-MSFT Nov 3, 2022
8605a4e
Remove test_Feedback.cs
daxian-dbw Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/System.Management.Automation/engine/Modules/SwitchProcessCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ protected override void EndProcessing()
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
CommandBaseStrings.NativeCommandNotFound,
command
WithCommand[0]
)
),
"CommandNotFound",
ErrorCategory.InvalidArgument,
WithCommand
WithCommand[0]
)
);
}
Expand Down
7 changes: 7 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ Describe 'Switch-Process tests for Unix' -Tags 'CI' {
$out = pwsh -noprofile -outputformat text -command { exec /bin/echo 1 -w 2 }
$out | Should -BeExactly '1 -w 2'
}

It 'Error is returned if target command is not found' {
$invalidCommand = 'doesNotExist'
$e = { Switch-Process $invalidCommand } | Should -Throw -ErrorId 'CommandNotFound,Microsoft.PowerShell.Commands.SwitchProcessCommand' -PassThru
$e.Exception.Message | Should -BeLike "*'$invalidCommand'*"
$e.TargetObject | Should -BeExactly $invalidCommand
}
}

Describe 'Switch-Process for Windows' -Tag 'CI' {
Expand Down