-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Apply expected file permissions to linux files after authenticode signing #18643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply expected file permissions to linux files after authenticode signing #18643
Conversation
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6c7a584 to
06fc605
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
/backport to release/v7.3.1 |
|
🎉 Handy links: |
|
/backport to release/v7.2.9 |
This comment was marked as outdated.
This comment was marked as outdated.
|
/backport to release/v7.2.9 |
PR Summary
When trying to authenticode sign files on Windows the linux file permissions are lost. We store them in a json file and then re-apply them.
Fixes #18495
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).