-
Notifications
You must be signed in to change notification settings - Fork 8.1k
[release/v7.3.1] Fix Switch-Process to copy the current env to the new process
#18631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| private static extern int Exec(string path, string?[] args, string?[] env); | ||
|
|
||
| // leverage .NET runtime's native library which abstracts the need to handle different OS and architectures for termios api | ||
| [DllImport("libSystem.Native", EntryPoint = "SystemNative_ConfigureTerminalForChildProcess")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR intended to pull in both Switch-Process fixes? This DllImport is here from the other one, but isn't used
|
replaced by #18632 |
Backport of #18452