Skip to content

[release/v7.3.1] Fix Switch-Process to set termios appropriate for child process #18572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 3 commits into from
Nov 21, 2022
+7 −1
Merged

[release/v7.3.1] Fix Switch-Process to set termios appropriate for child process #18572

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5969eee
add getting and setting termios
SteveL-MSFT Nov 4, 2022
e80367a
chanage to use .NET exported function
SteveL-MSFT Nov 4, 2022
354c779
add comments
SteveL-MSFT Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/System.Management.Automation/engine/Modules/SwitchProcessCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,12 @@ protected override void EndProcessing()
// need null terminator at end
execArgs[execArgs.Length - 1] = null;

// setup termios for a child process as .NET modifies termios dynamically for use with ReadKey()
ConfigureTerminalForChildProcess(true);
int exitCode = Exec(command.Source, execArgs);

if (exitCode < 0)
{
ConfigureTerminalForChildProcess(false);
ThrowTerminatingError(
new ErrorRecord(
new Exception(
Expand Down Expand Up @@ -108,6 +110,10 @@ protected override void EndProcessing()
CharSet = CharSet.Ansi,
SetLastError = true)]
private static extern int Exec(string path, string?[] args);

// leverage .NET runtime's native library which abstracts the need to handle different OS and architectures for termios api
[DllImport("libSystem.Native", EntryPoint = "SystemNative_ConfigureTerminalForChildProcess")]
private static extern void ConfigureTerminalForChildProcess([MarshalAs(UnmanagedType.Bool)] bool childUsesTerminal);
}
}

Expand Down