-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Change exec from alias to function to handle arbitrary args
#18567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1
Outdated
Show resolved
Hide resolved
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
/backport to release/v7.3.1 |
PR Summary
Previously
execwas an alias toswitch-process. The problem is if you useexecwith args that contain something like-wwhich PowerShell tries to bind to-WithCommand(parameter forSwitch-Process) then the other args try to get bound to positional parameters which do not exist. So something likeexec /bin/echo 1 -w 2fails whereas it should simply replace the currentpwshwithechoand emit "1 -w 2".The fix is to change from an alias to a function so that all the args get passed to
Switch-Parameterby using-WithCommandexplicitly so the remaining args get handled correctly.PR Context
Fix #18561
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.execis now a function and not an alias MicrosoftDocs/PowerShell-Docs#9444(which runs in a different PS Host).