Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Nov 14, 2022

PR Summary

Don't install based on build-id for RPM

PR Context

Fixes #18498

PR Checklist

@pull-request-quantifier-deprecated

This PR has 1 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -0
Percentile : 0.4%

Total files changed: 1

Change summary by file extension:
.psm1 : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost assigned anmenaga Nov 14, 2022
@TravisEz13
Copy link
Member Author

manually confirmed that the packages no longer has the build id files:

Older Package:

> rpm -q --list powershell-preview.rpm | sls -Pattern '^/usr/lib/\.'
/usr/lib/.build-id
/usr/lib/.build-id/14
/usr/lib/.build-id/14/3cfe905ff96a6c99d751564c189c05096e03c7

New package:

> rpm -q --list powershell-preview-7.3.0_preview.9-1.rh.x86_64.rpm | sls -Pattern '^/usr/lib/\.'

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 15, 2022
@TravisEz13 TravisEz13 merged commit f38369f into master Nov 15, 2022
@TravisEz13
Copy link
Member Author

/backport to release/v7.3.1

@tetiana-pozniakova
Copy link

@TravisEz13 hello, I'm not really familiar with how it all works but I need this fix and couldn't install this powershell-preview-7.3.0_preview.9-1.rh.x86_64.rpm version on fedora since it doesn't seem to be available in the package manager. Is there any timelines on the next release or maybe any advice on how to get this preview installed?

@TravisEz13
Copy link
Member Author

We release previews on a monthly cadence.
There is a bot that will update the PR when it is released into preview.
You can follow the 7.3.1 PR (above your comment) for when it will get into 7.3.

@ghost
Copy link

ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13
Copy link
Member Author

/backport to release/v7.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packaging conflict between powershell-7.3.0-1.rh.x86_64 and dotnet-apphost-pack-7.0-7.0.0-1.x86_64 on Fedora/RHEL

5 participants