-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update build.psm1 to require pwsh 7.0 #18556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@adityapatwardhan @TravisEz13 Can you review and see if you have any concerns? |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
TravisEz13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still many places we use Windows PowerShell
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment. |
|
I see #19040 reverted the changes to Line 22 in e6e34ad
Line 22 in 089212c
|
build.psm1runs on pwsh since #18508.