Fix native access violation (#18545) #18547

chrullrich · 2022-11-13T11:54:45Z

PR Summary

This fixes a crash caused by an incorrect declaration of a native function.

PR Context

The error occurs only when running x86 pwsh on Windows 11 22H2, the first Windows version that has WldpCanExecuteFile().

PR Checklist

The error occurs only when running x86 pwsh on x64 Windows 11 22H2, the first Windows version that has WldpCanExecuteFile().

pull-request-quantifier-deprecated · 2022-11-13T11:54:49Z

This PR has 1 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +1 -0
Percentile : 0.4%

Total files changed: 1

Change summary by file extension:
.cs : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

iSazonov · 2022-11-14T04:10:24Z

We need to backport to 7.3 I believe.

@chrullrich We started to migrate to from DllImport to LibraryImport. If you have an interest/experience with LibraryImport welcome to do that fix in follow PR (after we merge the PR).

xtqqczze · 2022-11-14T05:24:05Z

https://learn.microsoft.com/en-us/windows/win32/api/wldp/nf-wldp-wldpcanexecutefile

WldpCanExecuteFile - Win32 apps
Queries whether the execution policy allows execution of the code in the supplied file.

SteveL-MSFT · 2022-11-14T20:59:24Z

src/System.Management.Automation/security/wldpNativeMethods.cs

            [DefaultDllImportSearchPathsAttribute(DllImportSearchPath.System32)]
            [DllImportAttribute("wldp.dll", EntryPoint = "WldpCanExecuteFile")]
            internal static extern int WldpCanExecuteFile(
+                [MarshalAs(UnmanagedType.LPStruct)]


Should we add a comment here that this is needed because the first argument is a REFGUID?

If I figured it out, so can anyone else. The signature of the native function isn't secret, after all. On the other hand, I would quite like it if all declarations of native functions had their full signature next to them.

The docs for LPStruct DO indicate that this should ONLY be used for REFGUID, but someone not familiar with that may not understand the connection between this type and GUID.

I have made a suggestion to use the in modifier instead.

To allow anyone not familiar with the subject to understand why the attribute is there, you'd have to include a treatise on calling conventions and how C weirdly came up with the idea of passing structs on the stack. Anything less than that just ends up as a string of the same words you are trying to explain.

Link to https://learn.microsoft.com/en-us/dotnet/standard/native-interop/best-practices#guids ? That is what you are referring to above, I believe. That sentence doesn't say "the only type in the whole world that LPStruct should ever be used with is Guid", but "of the various ways of declaring a Guid argument, LPStruct should be used only with the ref kind". (If I find the time, I'll try and improve the Guid section of that page. I find it very confusing.)

I have made a suggestion to use the in modifier instead.

Doesn't in just mean the argument is effectively const on the receiving end? I admit I have never used it, but it does not look to me like it also means to pass the thing as a pointer.

Doesn't in just mean the argument is effectively const on the receiving end? I admit I have never used it, but it does not look to me like it also means to pass the thing as a pointer.

Oh, I take that back.

I'll leave it to the experts to decide whether it's correct, though. My C# is far from good enough.

xtqqczze · 2022-11-14T21:17:06Z

src/System.Management.Automation/security/wldpNativeMethods.cs

+                [MarshalAs(UnmanagedType.LPStruct)]
                Guid host,


Suggested change

[MarshalAs(UnmanagedType.LPStruct)]

Guid host,

in Guid host,

TravisEz13 · 2022-11-15T21:55:36Z

/backport to release/v7.3.1

iSazonov · 2022-11-16T02:54:24Z

@chrullrich Thanks for your contribution!

Fix native access violation (PowerShell#18545)

f07a49b

The error occurs only when running x86 pwsh on x64 Windows 11 22H2, the first Windows version that has WldpCanExecuteFile().

chrullrich requested review from PaulHigin and TravisEz13 as code owners November 13, 2022 11:54

pull-request-quantifier-deprecated bot added the Extra Small label Nov 13, 2022

ghost assigned PaulHigin Nov 13, 2022

iSazonov approved these changes Nov 14, 2022

View reviewed changes

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 14, 2022

daxian-dbw added the Backport-7.3.x-Consider label Nov 14, 2022

SteveL-MSFT reviewed Nov 14, 2022

View reviewed changes

SteveL-MSFT approved these changes Nov 14, 2022

View reviewed changes

xtqqczze reviewed Nov 14, 2022

View reviewed changes

TravisEz13 approved these changes Nov 14, 2022

View reviewed changes

PaulHigin approved these changes Nov 14, 2022

View reviewed changes

PaulHigin merged commit 8b7023d into PowerShell:master Nov 14, 2022

TravisEz13 added Backport-7.3.x-Approved and removed Backport-7.3.x-Consider labels Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

[release/v7.3.1] Fix native access violation (#18545) #18571

Merged

1 task

TravisEz13 added Backport-7.3.x-Done and removed Backport-7.3.x-Approved labels Nov 21, 2022

PaulHigin mentioned this pull request Nov 22, 2022

PowerShell 7.3.0 arm32 crashes on startup on arm64 Windows 11 #18612

Closed

5 tasks

Cheney-W mentioned this pull request Nov 29, 2022

[vcpkg] Lower the version of PowerShell to v7.2.7 microsoft/vcpkg#28058

Merged

Fix native access violation (#18545) #18547

Fix native access violation (#18545) #18547

Uh oh!

Conversation

chrullrich commented Nov 13, 2022 • edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

pull-request-quantifier-deprecated bot commented Nov 13, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

iSazonov commented Nov 14, 2022

Uh oh!

xtqqczze commented Nov 14, 2022 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveL-MSFT Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

chrullrich Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

SteveL-MSFT Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

xtqqczze Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

chrullrich Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

chrullrich Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

chrullrich Nov 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xtqqczze Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

TravisEz13 commented Nov 15, 2022

Uh oh!

iSazonov commented Nov 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

chrullrich commented Nov 13, 2022 •

edited by iSazonov

Loading

xtqqczze commented Nov 14, 2022 •

edited by unfurl-links bot

Loading

chrullrich Nov 14, 2022 •

edited

Loading