Skip to content

Add AllowInsecureRedirect switch to Web cmdlets #18546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 14 commits into from
Jan 12, 2023
Merged

Add AllowInsecureRedirect switch to Web cmdlets #18546

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6ee2238
Add SwitchParameter
CarloToso Nov 13, 2022
17198a3
ValidateParameters
CarloToso Nov 13, 2022
35a1eaf
Enable HTTP redirects from HTTPS
CarloToso Nov 13, 2022
a26d327
fix comment
CarloToso Nov 13, 2022
a84ab27
Add error to WebCmdletsStrings.resx
CarloToso Nov 13, 2022
f5eede6
fix WebCmdletsStrings.resx
CarloToso Nov 13, 2022
94f78cc
Comment out AllowInsecureRedirectMaximumRedirectionConflict
CarloToso Nov 15, 2022
e0ba600
AllowInsecureRedirect + MaximumRedirection
CarloToso Nov 15, 2022
e43e863
Fix Spaces
CarloToso Nov 15, 2022
9f61d36
Fix comment
CarloToso Nov 15, 2022
287bc61
Remove commented error message
CarloToso Nov 15, 2022
aa3be10
Merge branch 'PowerShell:master' into WebCmdlets-add--allowInsecureRe…
CarloToso Nov 22, 2022
b9703c3
Merge branch 'master' into WebCmdlets-add--allowInsecureRedirect
CarloToso Dec 16, 2022
d63ea55
Merge branch 'PowerShell:master' into WebCmdlets-add--allowInsecureRe…
CarloToso Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,12 @@ public abstract partial class WebRequestPSCmdlet : PSCmdlet
[Parameter]
public virtual SecureString Token { get; set; }

/// <summary>
/// Gets or sets the AllowInsecureRedirect property used to follow HTTP redirects from HTTPS.
/// </summary>
[Parameter]
public virtual SwitchParameter AllowInsecureRedirect { get; set; }

#endregion

#region Headers
Expand Down Expand Up @@ -968,7 +974,7 @@ internal virtual HttpClient GetHttpClient(bool handleRedirect)
}

// This indicates GetResponse will handle redirects.
if (handleRedirect)
if (handleRedirect || AllowInsecureRedirect)
{
handler.AllowAutoRedirect = false;
}
Expand Down Expand Up @@ -1313,7 +1319,7 @@ internal virtual HttpResponseMessage GetResponse(HttpClient client, HttpRequestM
_cancelToken = new CancellationTokenSource();
response = client.SendAsync(req, HttpCompletionOption.ResponseHeadersRead, _cancelToken.Token).GetAwaiter().GetResult();

if (keepAuthorization && IsRedirectCode(response.StatusCode) && response.Headers.Location is not null)
if ((keepAuthorization || (AllowInsecureRedirect && (WebSession.MaximumRedirection > 0 || WebSession.MaximumRedirection == -1))) && IsRedirectCode(response.StatusCode) && response.Headers.Location != null)
{
_cancelToken.Cancel();
_cancelToken = null;
Expand Down