Add AllowInsecureRedirect switch to Web cmdlets #18546

CarloToso · 2022-11-13T01:05:35Z

PR Summary

WebCmdlets add -AllowInsecureRedirect switch to enable HTTPS to HTTP redirect.
System.Net.Http.HttpClient disables insecure redirects, this PR bypasses the problem, unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag, so I have disabled using both of them toghether.
I'm eager to receive your feedback on this feature and some input on how to fix and re-enable the -MaximumRedirect flag.
I'm going to add some tests to show what works and what doesn't work yet.

PR Context

Fixes #2896 and #18541

PR Checklist

AllowInsecureRedirect

iSazonov · 2022-11-14T03:41:22Z

unfortunately at the moment I can't find a way to make it honor the -MaximumRedirects flag

PowerShell/src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs

Lines 1045 to 1049 in f5eede6

    
           // This indicates GetResponse will handle redirects. 
        
           if (handleRedirect) 
        
           { 
        
               handler.AllowAutoRedirect = false; 
        
           }

This says it is in GetResponse().

CarloToso · 2022-11-15T00:25:23Z

-AllowInsecureRedirect should now work with -MaximumRedirect.
I tested it with this code:

0..5 | ForEach-Object {Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
0..5 | ForEach-Object {Invoke-RestMethod https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_}
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect 
Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

I still have to remove some commented code.

CarloToso · 2022-11-15T00:41:16Z

Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck

Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect

0..5 | ForEach-Object {(Invoke-WebRequest https://mockbin.org/redirect/300?to=http://mockbin.org/redirect/301?to=https://mockbin.org/redirect/302?to=http://mockbin.org/redirect/303?to=http://mockbin.org/redirect/307?to=https://mockbin.org/status/200 -SkipHttpErrorCheck -AllowInsecureRedirect -MaximumRedirection $_).StatusCode}

Some inconsistent behaviours (increase redirects errors, status code 308) are fixed by PR #18536.

iSazonov · 2022-11-15T03:54:12Z

LGTM.

…direct

CarloToso · 2022-11-23T18:12:31Z

@PaulHigin please review, thanks!

ghost · 2022-12-01T02:01:03Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

CarloToso · 2022-12-16T22:14:22Z

Is something blocking this PR?

iSazonov · 2022-12-17T16:53:25Z

Is something blocking this PR?

Yes, holydays :-)
I hope MSFT team will start active work after Jan 1.
Until that I can consider minor style changes and discuss/review code for already triaged issues.

ghost · 2022-12-25T02:00:58Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

CarloToso · 2023-01-03T15:58:35Z

I think that after this PR is merged I can work on fixing #14531, it should be similar.

…direct

pull-request-quantifier-deprecated · 2023-01-04T23:57:50Z

This PR has 6 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +4 -2
Percentile : 2.4%

Total files changed: 1

Change summary by file extension:
.cs : +4 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

iSazonov · 2023-01-12T10:42:49Z

@please open new issue in Docs repository and add reference in the PR description.

CarloToso · 2023-01-12T11:16:58Z

@please open new issue in Docs repository and add reference in the PR description.

Done MicrosoftDocs/PowerShell-Docs#9689

ghost · 2023-03-14T22:27:34Z

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

CarloToso added 3 commits November 13, 2022 01:32

Add SwitchParameter

6ee2238

AllowInsecureRedirect

ValidateParameters

17198a3

Enable HTTP redirects from HTTPS

35a1eaf

CarloToso requested a review from PaulHigin as a code owner November 13, 2022 01:05

pull-request-quantifier-deprecated bot added the Extra Small label Nov 13, 2022

ghost assigned PaulHigin Nov 13, 2022

CarloToso added 3 commits November 13, 2022 02:06

fix comment

a26d327

Add error to WebCmdletsStrings.resx

a84ab27

fix WebCmdletsStrings.resx

f5eede6

CarloToso marked this pull request as draft November 14, 2022 10:48

CarloToso changed the title ~~Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS~~ WIP: Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Nov 14, 2022

CarloToso added 2 commits November 15, 2022 01:06

Comment out AllowInsecureRedirectMaximumRedirectionConflict

94f78cc

AllowInsecureRedirect + MaximumRedirection

e0ba600

CarloToso marked this pull request as ready for review November 15, 2022 00:29

CarloToso added 2 commits November 15, 2022 01:45

Fix Spaces

e43e863

Fix comment

9f61d36

Remove commented error message

287bc61

CarloToso changed the title ~~WIP: Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS~~ Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS Nov 15, 2022

iSazonov approved these changes Nov 15, 2022

View reviewed changes

CarloToso mentioned this pull request Nov 17, 2022

Webcmdlets display an error on https to http redirect #18595

Merged

22 tasks

Merge branch 'PowerShell:master' into WebCmdlets-add--allowInsecureRe…

aa3be10

…direct

ghost added the Review - Needed The PR is being reviewed label Dec 1, 2022

Merge branch 'master' into WebCmdlets-add--allowInsecureRedirect

b9703c3

ghost removed the Review - Needed The PR is being reviewed label Dec 17, 2022

ghost added the Review - Needed The PR is being reviewed label Dec 25, 2022

Merge branch 'PowerShell:master' into WebCmdlets-add--allowInsecureRe…

d63ea55

…direct

This was referenced Jan 6, 2023

Add PreserveHttpMethodOnRedirect switch to Web cmdlets #18894

Merged

Fix bug with managing redirection and keepAuthorization in Web cmdlets #18902

Merged

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 12, 2023

iSazonov assigned iSazonov and unassigned PaulHigin Jan 12, 2023

ghost removed the Review - Needed The PR is being reviewed label Jan 12, 2023

CarloToso mentioned this pull request Jan 12, 2023

Document WebCmdlets -AllowInsecureRedirect parameter MicrosoftDocs/PowerShell-Docs#9689

Closed

2 tasks

iSazonov changed the title ~~Webcmdlets -AllowInsecureRedirect -> follow HTTP redirects from HTTPS~~ Add AllowInsecureRedirect switch to Web cmdlets Jan 12, 2023

iSazonov merged commit ca4b616 into PowerShell:master Jan 12, 2023

CarloToso deleted the WebCmdlets-add--allowInsecureRedirect branch January 12, 2023 16:13

CarloToso mentioned this pull request Jan 13, 2023

Add tests for Allowinsecureredirect parameter in Web cmdlets #18939

Merged

CarloToso mentioned this pull request Jan 23, 2023

Invoke-WebRequest/Invoke-RestMethod doesn't error silently and doesn't return object #16247

Closed

5 tasks

ghost mentioned this pull request Mar 14, 2023

Invoke-WebRequest / Invoke-RestMethod fails to follow HTTP redirects from HTTPS #2896

Closed

CarloToso mentioned this pull request Apr 7, 2023

WebCmdlets check if absolute uri before checking scheme #19468

Merged

22 tasks

Add AllowInsecureRedirect switch to Web cmdlets #18546

Add AllowInsecureRedirect switch to Web cmdlets #18546

Uh oh!

Conversation

CarloToso commented Nov 13, 2022 • edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

iSazonov commented Nov 14, 2022

Uh oh!

CarloToso commented Nov 15, 2022

Uh oh!

CarloToso commented Nov 15, 2022

Uh oh!

iSazonov commented Nov 15, 2022

Uh oh!

CarloToso commented Nov 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 1, 2022

Uh oh!

CarloToso commented Dec 16, 2022

Uh oh!

iSazonov commented Dec 17, 2022

Uh oh!

ghost commented Dec 25, 2022

Uh oh!

CarloToso commented Jan 3, 2023

Uh oh!

pull-request-quantifier-deprecated bot commented Jan 4, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

iSazonov commented Jan 12, 2023

Uh oh!

CarloToso commented Jan 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CarloToso commented Nov 13, 2022 •

edited by iSazonov

Loading

CarloToso commented Nov 23, 2022 •

edited

Loading

CarloToso commented Jan 12, 2023 •

edited

Loading