-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Avoid depending on the pre-generated experimental feature list in private and CI builds #18484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
It's easier to review by ignoring the white spaces: |
|
🎉 Handy links: |
PR Summary
The pre-generated files
experimental-feature-windows.jsonandexperimental-feature-linux.jsonexist only for building purpose -- so that thepowershell.config.jsonfile can include all experimental features for the pre-release builds to enable all experimental features by default. (A little background context -- you cannot start the newly built pwsh when doing cross-compilation for ARM architectures)However, it turns out this becomes a burden to the developer who is working on an experimental feature -- they have to update those 2 files to make the new experimental feature enabled in CI builds and private builds. This makes declaring an experimental feature harder and more confusing, as there is no documentation saying that those 2 files need to be updated as part of creating an experimental feature.
This PR update
Start-PSBuildto avoid depending on those 2 files for private builds and CI builds. For release builds, since we have a GitHub Action workflow to update those 2 files daily, we should be good.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.