-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix Switch-Process to set termios appropriate for child process
#18467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Switch-Process to set termios appropriate for child process
#18467
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the best solution, literally restored the original terminal settings.
|
/backport to release/v7.3.1 |
PR Summary
.NET makes changes to termios for the purpose of
ReadKey()(and maybe other uses). So whenexecv()is called, the terminal is set not to echo. Unless the child process (likebash) sets up termios appropriately, echo is now disabled and needs to manually be reenabled. The fix is to leverage an exported function from .NET that sets up termios correctly for a child process.Manually validated on macOS with bash since using
pwshnon-interactively doesn't have a problem (as there isn't a TTY).PR Context
Fix #18433
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).