Skip to content

Do not remove penimc_cor3.dll from build#18438

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:ReAddPenImc
Nov 2, 2022
Merged

Do not remove penimc_cor3.dll from build#18438
daxian-dbw merged 2 commits intoPowerShell:masterfrom
adityapatwardhan:ReAddPenImc

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Nov 1, 2022 •
edited by daxian-dbw
Loading

PR Summary

Fix #18414

Do not remove penimc_cor3.dll from the build as it blocks WPF scenarios.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Nov 1, 2022
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Nov 1, 2022

This PR has 7 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +6 -1
Percentile : 2.8%

Total files changed: 2

Change summary by file extension:
.wxs : +4 -0
.psm1 : +2 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw
daxian-dbw approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit f9b6d12 into PowerShell:master Nov 2, 2022
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 2, 2022
@adityapatwardhan adityapatwardhan deleted the ReAddPenImc branch November 2, 2022 01:54
@adityapatwardhan
Copy link
Member Author

adityapatwardhan commented Nov 2, 2022

/backport to release/v7.3.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

@adityapatwardhan backporting to release/v7.3.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Do not remove `penimc_cor3.dll` from build
Applying: Fix wix file
Using index info to reconstruct a base tree...
M	assets/wix/files.wxs
Falling back to patching base and 3-way merge...
Auto-merging assets/wix/files.wxs
CONFLICT (content): Merge conflict in assets/wix/files.wxs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix wix file
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Nov 2, 2022
@adityapatwardhan
Do not remove penimc_cor3.dll from build (PowerShell#18438)
4a16ccc
@adityapatwardhan adityapatwardhan mentioned this pull request Nov 2, 2022
Merged
22 tasks
@iSazonov iSazonov mentioned this pull request Nov 2, 2022
Closed
5 tasks
adityapatwardhan added a commit that referenced this pull request Nov 3, 2022
@adityapatwardhan
Do not remove penimc_cor3.dll from build (#18438) (#18441)
8f5db72
@ghost
Copy link

ghost commented Nov 9, 2022

🎉v7.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request May 26, 2023
@adityapatwardhan
Do not remove penimc_cor3.dll from build (PowerShell#18438)
29b7c66
adityapatwardhan added a commit that referenced this pull request Jun 14, 2023
@adityapatwardhan
Do not remove penimc_cor3.dll from build (#18438)
28c6dd4
@ghost
Copy link

ghost commented Jun 27, 2023

🎉v7.2.12 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@daxian-dbw daxian-dbw

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scripts generating WPF fail after upgrading to PowerShell 7.3.0-rc.1

3 participants

@adityapatwardhan @daxian-dbw @TravisEz13