Skip to content

Conversation

@urizen-source
Copy link
Contributor

@urizen-source urizen-source commented Oct 25, 2022

Corrects incorrect cmdlet name in script, which has been causing for instance "Restart-Computer -Computername otherserver -Wait -For Powershell" to never complete.
Also fixes "Restart-Computer -ComputerName $_ -Force -Wait -Timeout 1800" where powershell is implicit.

PR Context

Resolves #12232
Also resolves #11002 which is also dependant on this powershell script, and it hangs in the same place.
Issue is that the powershell script invoked has an exception because of the incorrect cmdlet-name, and this exception is silently ignored, so it never determines that any powershell is reachable on restarted servers.

PR Checklist

@pull-request-quantifier-deprecated

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.cs : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost assigned TravisEz13 Oct 25, 2022
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov requested a review from JamesWTruher October 26, 2022 03:23
@iSazonov
Copy link
Collaborator

Should we backport this?

@daxian-dbw daxian-dbw added Backport-7.2.x-Consider CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Oct 26, 2022
@daxian-dbw daxian-dbw merged commit a06d908 into PowerShell:master Oct 26, 2022
@iSazonov
Copy link
Collaborator

@urizen-source Thanks for your contribution!

@adityapatwardhan
Copy link
Member

Since 7.2.x is LTS lets have some bake time for this in 7.3.x and consider this for next 7.2 release.

@adityapatwardhan
Copy link
Member

/backport to release/v7.3.0

@ghost
Copy link

ghost commented Nov 9, 2022

🎉v7.3.0 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13
Copy link
Member

Triaging backports: Waiting for next release before backporting to LTS in order to give some time to discover issue.

@TravisEz13
Copy link
Member

/backport to release/v7.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done Backport-7.3.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restart-Computer wait for PowerShell never completes Restart-Computer -cn -Force -Wait -Timeout is broken in latest build.

5 participants