Skip to content

Remove unsupported versions from PSCompatibleVersions #18346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xtqqczze wants to merge 3 commits into from
Closed

Remove unsupported versions from PSCompatibleVersions #18346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b31695e
Remove `1.0` and `2.0` from `PSCompatibleVersions`
xtqqczze Oct 21, 2022
830fd33
Revert "Remove `1.0` and `2.0` from `PSCompatibleVersions`"
xtqqczze Oct 22, 2022
8415e01
Remove unsupported versions from version table
xtqqczze Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/System.Management.Automation/engine/PSVersionInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,8 @@ private const int Version_Major
private static readonly Version s_psV2Version = new(2, 0);
private static readonly Version s_psV3Version = new(3, 0);
private static readonly Version s_psV4Version = new(4, 0);
private static readonly Version s_psV5Version = new(5, 0);
private static readonly Version s_psV51Version = new(5, 1);
private static readonly Version s_psV6Version = new(6, 0, 0);
private static readonly Version s_psV61Version = new(6, 1, 0);
private static readonly Version s_psV62Version = new(6, 2, 0);
private static readonly Version s_psV7Version = new(7, 0, 0);
private static readonly Version s_psV71Version = new(7, 1, 0);
private static readonly Version s_psV72Version = new(7, 2, 0);
private static readonly Version s_psVersion;
private static readonly SemanticVersion s_psSemVersion;
Expand All @@ -97,7 +92,7 @@ static PSVersionInfo()
s_psVersionTable[PSVersionName] = s_psSemVersion;
s_psVersionTable[PSEditionName] = PSEditionValue;
s_psVersionTable[PSGitCommitIdName] = GitCommitId;
s_psVersionTable[PSCompatibleVersionsName] = new Version[] { s_psV1Version, s_psV2Version, s_psV3Version, s_psV4Version, s_psV5Version, s_psV51Version, s_psV6Version, s_psV61Version, s_psV62Version, s_psV7Version, s_psV71Version, s_psV72Version, s_psVersion };
s_psVersionTable[PSCompatibleVersionsName] = new Version[] { s_psV1Version, s_psV2Version, s_psV3Version, s_psV4Version, s_psV51Version, s_psV7Version, s_psV72Version, s_psVersion };
s_psVersionTable[SerializationVersionName] = new Version(InternalSerializer.DefaultVersion);
s_psVersionTable[PSRemotingProtocolVersionName] = RemotingConstants.ProtocolVersion;
s_psVersionTable[WSManStackVersionName] = GetWSManStackVersion();
Expand Down
2 changes: 1 addition & 1 deletion test/powershell/Host/PSVersionTable.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Describe "PSVersionTable" -Tags "CI" {
$unexpectectGitCommitIdPattern = $fullVersionPattern
}

$powerShellVersions = "1.0", "2.0", "3.0", "4.0", "5.0", "5.1", "6.0", "6.1", "6.2", "7.0", "7.1", "7.2", "7.3"
$powerShellVersions = "1.0", "2.0", "3.0", "4.0", "5.1", "7.0", "7.2", "7.3"
$powerShellCompatibleVersions = $PSVersionTable.PSCompatibleVersions |
ForEach-Object {$_.ToString(2).SubString(0,3)}
}
Expand Down