Skip to content

Remove FusionAssemblyIdentity and GlobalAssemblyCache #18334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 2 commits into from
Oct 24, 2022
Merged

Remove FusionAssemblyIdentity and GlobalAssemblyCache #18334

daxian-dbw merged 2 commits into from
Oct 24, 2022

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Oct 20, 2022 •
edited
Loading

PR Summary

This has never been used in pwsh and is unlikely to be used to handle meta-information in the GAC.

Contribute to #18330

PR Context

PR Checklist

@iSazonov
Remove FusionAssemblyIdentity file
aa7b998 
This has never been used in pwsh and is unlikely to be used to handle meta-information in the GAC.
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 20, 2022
@iSazonov iSazonov requested a review from SteveL-MSFT October 20, 2022 04:09
@iSazonov iSazonov requested a review from daxian-dbw as a code owner October 20, 2022 04:09
@xtqqczze
Copy link
Contributor

xtqqczze commented Oct 21, 2022

Since .NET Core, there is no Global Assembly Cache :p

daxian-dbw
daxian-dbw approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xtqqczze
xtqqczze reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@xtqqczze xtqqczze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov search for "// Code in this file was copied from https://github.com/dotnet/roslyn" shows src\System.Management.Automation\engine\parser\GlobalAssemblyCache.cs. I think the PR could remove this as well.

@xtqqczze
Copy link
Contributor

xtqqczze commented Oct 21, 2022

Contributes to #4357.

@daxian-dbw
Copy link
Member

daxian-dbw commented Oct 21, 2022

Good catch @xtqqczze! @iSazonov Can you remove src\System.Management.Automation\engine\parser\GlobalAssemblyCache.cs in this PR as well?

@xtqqczze
Copy link
Contributor

xtqqczze commented Oct 21, 2022 •
edited
Loading

See #13305 for discussion on GlobalAssemblyCache.cs.

@xtqqczze
Copy link
Contributor

xtqqczze commented Oct 21, 2022 •
edited
Loading

Good catch @xtqqczze! @iSazonov Can you remove src\System.Management.Automation\engine\parser\GlobalAssemblyCache.cs in this PR as well?

Yeah, GlobalAssemblyCache references FusionAssemblyIdentity so both should be removed at the same time.

Additionally:

PowerShell/src/System.Management.Automation/engine/parser/Compiler.cs

Line 2791 in 4b9b078

Microsoft.CodeAnalysis.GlobalAssemblyCache.ResolvePartialName(assemblyName, out assemblyFileName);

PowerShell/src/System.Management.Automation/engine/parser/Parser.cs

Line 5079 in 4b9b078

GlobalAssemblyCache.ResolvePartialName(assemblyName, out assemblyFileName);

@xtqqczze
Copy link
Contributor

xtqqczze commented Oct 21, 2022 •
edited
Loading

We can remove all GlobalAssemblyCache code as it is not compiled. (#if !CORECLR)

@daxian-dbw
Copy link
Member

daxian-dbw commented Oct 21, 2022

The support in loading GAC assemblies is in PowerShellAssemblyLoadContext, not related to these 2 files.

@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Oct 21, 2022

This PR has 298 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +0 -298
Percentile : 69.8%

Total files changed: 4

Change summary by file extension:
.cs : +0 -298

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov changed the title Remove FusionAssemblyIdentity file Remove FusionAssemblyIdentity and GlobalAssemblyCache Oct 21, 2022
@iSazonov
Copy link
Collaborator Author

iSazonov commented Oct 21, 2022

@xtqqczze Thanks! GlobalAssemblyCache removed.

@xtqqczze
Copy link
Contributor

xtqqczze commented Oct 21, 2022

LGTM

daxian-dbw
daxian-dbw approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit ece26bc into PowerShell:master Oct 24, 2022
@iSazonov iSazonov deleted the remove-fai branch October 25, 2022 03:53
@ghost
Copy link

ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

+1 more reviewer

@xtqqczze xtqqczze xtqqczze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iSazonov @xtqqczze @daxian-dbw