-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Replace command-error suggestion with new implementation based on subsystem plugin #18252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/System.Management.Automation/engine/Subsystem/FeedbackSubsystem/IFeedbackProvider.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/Subsystem/FeedbackSubsystem/IFeedbackProvider.cs
Show resolved
Hide resolved
src/System.Management.Automation/engine/Subsystem/FeedbackSubsystem/IFeedbackProvider.cs
Outdated
Show resolved
Hide resolved
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is great, but should be an experimental feature separate from PSCommandNotFoundSuggestion feature.
src/System.Management.Automation/engine/Subsystem/FeedbackSubsystem/IFeedbackProvider.cs
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@SteveL-MSFT Please take another look when you have time. All to-dos are done (please see the to-do list in the PR description). |
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Summary
Replace command-error suggestion with new implementation based on subsystem plugin.
Two built-in feedback providers are included:
GeneralCommandErrorFeedback, serves the same suggestion functionality existing todayUnixCommandNotFound, available on Linux, utilize thecommand-not-foundcommand on Linux platforms, to provide feedback similar asbashdoes.The
UnixCommandNotFoundserves as both a feedback provider and a predictor. The suggestion fromcommand-not-foundcommand is used both for providing the feedback when command cannot be found in an interactive run, and for providing predictive intellisense results for the next command line.To-do's
SeparateWill moveUnixCommandNotFoundout as a moduleUnixCommandNotFoundtoUnixCompletermodule, but this is not blocking the PR.This is a screenshot after applying the styles for feedback rendering:
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.