Skip to content

Conversation

@dkaszews
Copy link
Contributor

@dkaszews dkaszews commented Aug 2, 2022

PR Summary

Change runtime detection when not provided with explicit -Runtime to always use dotnet --info and their Platform OS and Architecture,

Fixes #17801

PR Context

This fixes runtime detection on Linux, which previously always defaulted to x64, even on ARM. This meant that Start-PSBuild required explicit -Runtime linux-arm64, which Start-DevPowerShell did not work at all as it had no option of specifying runtime. Also simplifies Windows and OSX code, delegating detection work to dotnet who is the main consumer of runtime option anyways.

PR Checklist

@dkaszews
Copy link
Contributor Author

dkaszews commented Aug 2, 2022

Can I get help with resolving failing Windows checks? I looked at logs on Azure, but cannot see anything helpful. I could limit this change to do Windows old way, but would prefer to unify all platforms.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 2, 2022
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 3, 2022
@dkaszews dkaszews requested a review from daxian-dbw August 3, 2022 15:07
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made a minor update on the comments.

@pull-request-quantifier-deprecated

This PR has 32 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +18 -14
Percentile : 12.8%

Total files changed: 1

Change summary by file extension:
.psm1 : +18 -14

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@dkaszews
Copy link
Contributor Author

dkaszews commented Aug 3, 2022

Thanks for approve. Any idea why MacOS CI is failing now? It says Denial of Service tests are completing too fast? It worked fine before and you only updated comments 😕

@PaulHigin PaulHigin merged commit 8950962 into PowerShell:master Aug 3, 2022
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 8, 2022
@ghost
Copy link

ghost commented Aug 11, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start-PSBuild -Runtime always defaults to x64 on Linux

5 participants