-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Detect default runtime using dotnet --info in build.psm1 #17818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect default runtime using dotnet --info in build.psm1 #17818
Conversation
|
Can I get help with resolving failing Windows checks? I looked at logs on Azure, but cannot see anything helpful. I could limit this change to do Windows old way, but would prefer to unify all platforms. |
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Made a minor update on the comments.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
Thanks for approve. Any idea why MacOS CI is failing now? It says Denial of Service tests are completing too fast? It worked fine before and you only updated comments 😕 |
|
🎉 Handy links: |
PR Summary
Change runtime detection when not provided with explicit
-Runtimeto always usedotnet --infoand theirPlatform OSandArchitecture,Fixes #17801
PR Context
This fixes runtime detection on Linux, which previously always defaulted to
x64, even on ARM. This meant thatStart-PSBuildrequired explicit-Runtime linux-arm64, whichStart-DevPowerShelldid not work at all as it had no option of specifying runtime. Also simplifies Windows and OSX code, delegating detection work todotnetwho is the main consumer ofruntimeoption anyways.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).