Skip to content

Conversation

@fflaten
Copy link
Contributor

@fflaten fflaten commented Jul 27, 2022

PR Summary

Adds a helper in EnumSingleTypeConverter to get enum names-array.
Updates switch statement completer to use the new helper instead of string joining + splitting.

PR Context

Related #17750 (comment)

There's another occurrence in CompletionCompleters.cs which is replaced as part of the PR above.

PR Checklist

@fflaten fflaten changed the title Use helper in EnumSingleTypeConverter to get enum names-array Add helper in EnumSingleTypeConverter to get enum names-array Jul 27, 2022
@fflaten
Copy link
Contributor Author

fflaten commented Jul 27, 2022

Feels like random failures. Rerun?

@fflaten
Copy link
Contributor Author

fflaten commented Jul 28, 2022

Just noticed that #17684 plan to replace this code. This PR can be closed if the other one is accepted.

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 5, 2022
@ghost
Copy link

ghost commented Aug 5, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 2, 2025
@iSazonov iSazonov changed the title Add helper in EnumSingleTypeConverter to get enum names-array Add helper in EnumSingleTypeConverter to get enum names as array Jan 2, 2025
@iSazonov iSazonov assigned iSazonov and unassigned adityapatwardhan Jan 2, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Jan 2, 2025
@iSazonov iSazonov merged commit c0d7fb7 into PowerShell:master Jan 2, 2025
38 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented Jan 2, 2025

📣 Hey @fflaten, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@fflaten fflaten deleted the cleanup-getenumnames branch January 2, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants