-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix Test-Json not handling non-object types at root #17741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iSazonov
merged 2 commits into
PowerShell:master
from
dkaszews:dkaszews-test-json-root-not-object
Jul 25, 2022
Merged
Fix Test-Json not handling non-object types at root #17741
iSazonov
merged 2 commits into
PowerShell:master
from
dkaszews:dkaszews-test-json-root-not-object
Jul 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkaszews
commented
Jul 21, 2022
test/powershell/Modules/Microsoft.PowerShell.Utility/Test-Json.Tests.ps1
Show resolved
Hide resolved
dkaszews
commented
Jul 21, 2022
test/powershell/Modules/Microsoft.PowerShell.Utility/Test-Json.Tests.ps1
Show resolved
Hide resolved
iSazonov
reviewed
Jul 22, 2022
test/powershell/Modules/Microsoft.PowerShell.Utility/Test-Json.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Utility/Test-Json.Tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
approved these changes
Jul 22, 2022
daxian-dbw
approved these changes
Jul 22, 2022
Member
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PaulHigin
approved these changes
Jul 22, 2022
SteveL-MSFT
approved these changes
Jul 25, 2022
Collaborator
|
@dkaszews Thanks for your contribution! |
|
🎉 Handy links: |
22 tasks
RobertKlohr
referenced
this pull request
in RobertKlohr/PowerShellForLockpath
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Test-Jsonincorrectly parsed JSON asJObject, which failed if the root type was not an object, but array, string, number, etc. @mklement0 suggested to change it toJTokenwhich matches all types, which I verified to be a one-line fix.Fixes #11384
PR Context
Test-Jsoncurrently fails if the root type is not an object, despiteConvertFrom-JsonandConvertTo-Jsonhandling them without a problem. This leads to confusing case of1 | ConvertTo-Json | Test-Jsonfailing with a non-specific error "Cannot parse JSON".This bug is most apparent when trying to validate a JSON schema where the root is not a single object, but instead an array of objects. However, as in example above, it also impacts cases without schema, where someone might use
Test-Jsonas a shorthand for puttingConvertFrom-Jsonin a try-catch, which is exactly how it should be used when you don't care about content, just whether it is valid.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).