Skip to content

Remove PSNativePSPathResolution experimental feature #17670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 4 commits into from
Jul 19, 2022
Merged

Remove PSNativePSPathResolution experimental feature #17670

daxian-dbw merged 4 commits into from
Jul 19, 2022

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jul 12, 2022 •
edited
Loading

PR Summary

The PSNativePSPathResolution experimental feature hit a roadblock where single quotes should treat the string as literal. However, the NativeCommandProcessor no longer has this context and only the string value. It's not worth the effort to try to pass this context through as the use cases for this feature are minimal.

PR Context

Fix #13644
Fix #13640
Fix #17278

PR Checklist

@ghost ghost assigned anmenaga Jul 12, 2022
@SteveL-MSFT SteveL-MSFT mentioned this pull request Jul 12, 2022
Closed
2 tasks
@rkeithhill
Copy link
Collaborator

rkeithhill commented Jul 13, 2022

Bummer, I'll miss being able to do code ~\foo.ps1. 😢

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 13, 2022 •
edited
Loading

@rkeithhill but if you tab complete, it will resolve to the full path so just one extra key press. Maybe we can retain just the tilde=homedir on Windows as a separate PR. Of course, you'd still have the same problem where '~\foo.ps1' would still get resolved and not treated as a literal (and no way to indicate it should be a literal)

Or just create a code function that resolves the path and then pass it to code.exe :)

@rkeithhill
Copy link
Collaborator

rkeithhill commented Jul 13, 2022

Tab will have to do. :-)

@MartinGC94
Copy link
Contributor

MartinGC94 commented Jul 13, 2022

if you tab complete, it will resolve to the full path so just one extra key press.

It does that now but is that the desired behavior? There's an open issue #5350 about stopping tab completion from replacing variables and ~ because it makes scripts less portable.

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 13, 2022

I'm closing this PR for now. Due to some work for a different Experimental Feature PSNativeCommandArgumentPassing, the actual extent seems to be available within the NativeCommandProcessor thus it can determine if single or double quotes, so let me see if I can fix the original reported issues instead of removing this feature.

@SteveL-MSFT SteveL-MSFT reopened this Jul 13, 2022
@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 13, 2022

Actually, rereading #13644 it's not really a solvable problem if the args is passed as variables since the context of single vs double is lost already.

JamesWTruher
JamesWTruher approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine, my own concern is that we don't have a negative test to ensure we've removed the behavior we want.

@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Jul 18, 2022

This PR has 211 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +52 -159
Percentile : 61.1%

Total files changed: 5

Change summary by file extension:
.json : +0 -2
.cs : +48 -89
.ps1 : +4 -68

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit b7c875b into PowerShell:master Jul 19, 2022
@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned anmenaga Jul 19, 2022
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Jul 19, 2022
@SteveL-MSFT SteveL-MSFT deleted the remove-native-pspath branch July 19, 2022 16:22
@ghost
Copy link

ghost commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Aug 12, 2022
Closed
Closed
@ghost ghost mentioned this pull request Aug 12, 2022
Closed
@jhoneill jhoneill mentioned this pull request Aug 29, 2022
Closed
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

+1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw daxian-dbw

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Large

Projects

None yet

Milestone

No milestone

6 participants

@SteveL-MSFT @rkeithhill @MartinGC94 @daxian-dbw @JamesWTruher @anmenaga