Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented May 24, 2022

Backport 38909f7

# Conflicts:
#	test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
# 38909f7
@pull-request-quantifier-deprecated

This PR has 7427 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +4795 -2632
Percentile : 100%

Total files changed: 157

Change summary by file extension:
.psm1 : +760 -743
.yml : +1098 -274
.spelling : +28 -1
.props : +3 -2
.md : +944 -798
.json : +926 -15
.txt : +118 -57
.wxs : +137 -5
.config : +1 -1
.yaml : +0 -0
.csproj : +42 -42
.cs : +176 -210
.psd1 : +17 -32
.resx : +6 -0
.lock : +0 -0
.ps1 : +538 -92
docker/tests/Templates/centos7/Dockerfile : +0 -19
docker/tests/Templates/debian.9/Dockerfile : +0 -25
docker/tests/Templates/fedora28/Dockerfile : +0 -22
docker/tests/Templates/fxdependent-centos7/Dockerfile : +0 -25
docker/tests/Templates/fxdependent-debian.9/Dockerfile : +0 -26
docker/tests/Templates/fxdependent-dotnetsdk-latest/Dockerfile : +0 -26
docker/tests/Templates/fxdependent-fedora28/Dockerfile : +0 -32
docker/tests/Templates/fxdependent-opensuse42.3/Dockerfile : +0 -35
docker/tests/Templates/fxdependent-ubuntu16.04/Dockerfile : +0 -33
docker/tests/Templates/fxdependent-ubuntu18.04/Dockerfile : +0 -26
docker/tests/Templates/opensuse42.3/Dockerfile : +0 -31
docker/tests/Templates/ubuntu16.04/Dockerfile : +0 -25
docker/tests/Templates/ubuntu18.04/Dockerfile : +0 -25
test/docker/networktest/Dockerfile : +1 -1
tools/releaseBuild/Images/microsoft_powershell_alpine3/Dockerfile : +0 -9

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 changed the base branch from master to release/v7.2.5 May 24, 2022 17:46
@TravisEz13 TravisEz13 changed the title tls test fixes Update TLS test based on current platform settings May 24, 2022
@TravisEz13 TravisEz13 marked this pull request as ready for review May 24, 2022 20:05
@adityapatwardhan adityapatwardhan merged commit 8af2f5c into PowerShell:release/v7.2.5 May 24, 2022
@TravisEz13 TravisEz13 deleted the tls-test-fixes branch May 31, 2022 19:11
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
22 tasks
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jun 16, 2022
@ghost
Copy link

ghost commented Jun 21, 2022

🎉v7.2.5 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done CL-Test Indicates that a PR should be marked as a test change in the Change Log Extra Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants