Skip to content

Conversation

@github-actions
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@adityapatwardhan
Copy link
Member

Once the PR #17063 is merged into master and the GitHub Action is run. This PR will be updated to work correctly.

@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22174.6 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22175.2 Mar 25, 2022
@github-actions github-actions bot force-pushed the dotnet_update branch 4 times, most recently from cf82ecb to 4d911b9 Compare March 28, 2022 13:15
@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22175.2 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.1 Mar 29, 2022
@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.1 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.4 Mar 31, 2022
@github-actions github-actions bot force-pushed the dotnet_update branch 7 times, most recently from 62431e1 to 12a1d68 Compare April 6, 2022 13:17
@PaulHigin
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@iSazonov
Copy link
Collaborator

iSazonov commented Apr 7, 2022

/rebase

@github-actions github-actions bot force-pushed the dotnet_update branch 2 times, most recently from a91bc4f to 52bd0c8 Compare May 9, 2022 13:21
@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.4 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.4.22252.9 May 9, 2022
@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.4.22252.9 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.4 May 10, 2022
@PaulHigin
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.4 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.4.22252.9 May 10, 2022
@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.4.22252.9 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.4 May 11, 2022
@github-actions github-actions bot changed the title Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.3.22179.4 Update .NET SDK version from 7.0.100-preview.2.22153.17 to 7.0.100-preview.4.22252.9 May 11, 2022
@pull-request-quantifier-deprecated

This PR has 166 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Medium
Size       : +37 -129
Percentile : 53.2%

Total files changed: 14

Change summary by file extension:
.wxs : +12 -76
.json : +1 -1
.csproj : +21 -21
.cs : +3 -3
.ps1 : +0 -28

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label May 12, 2022
@adityapatwardhan adityapatwardhan merged commit 38909f7 into master May 12, 2022
@adityapatwardhan adityapatwardhan deleted the dotnet_update branch May 12, 2022 01:56
@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request May 24, 2022
# Conflicts:
#	test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
# 38909f7
adityapatwardhan pushed a commit that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants