Skip to content

Conversation

@daxian-dbw
Copy link
Member

PR Summary

Update AzureFileCopy task and fix the syntax for specifying pool.
The former causes 2 jobs in release pipeline to fail, and the latter causes the vpack build to fail.

PR Checklist

@pull-request-quantifier-deprecated

This PR has 11 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +6 -5
Percentile : 4.4%

Total files changed: 3

Change summary by file extension:
.yml : +6 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned PaulHigin Mar 16, 2022
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 16, 2022
@daxian-dbw daxian-dbw merged commit 8d08301 into PowerShell:master Mar 16, 2022
@daxian-dbw daxian-dbw deleted the release branch March 16, 2022 22:55
@ghost
Copy link

ghost commented Mar 21, 2022

🎉v7.3.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan
Copy link
Member

/backport to release/v7.0.12

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

Started backporting to release/v7.0.12: https://github.com/PowerShell/PowerShell/actions/runs/2380417716

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@adityapatwardhan
Copy link
Member

/backport to release/v7.2.5

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2022

Started backporting to release/v7.2.5: https://github.com/PowerShell/PowerShell/actions/runs/2380419672

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions
Copy link
Contributor

@adityapatwardhan an error occurred while backporting to release/v7.2.5, please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/v7.2.5 and backport/pr-17013-to-release/v7.2.5"}

@adityapatwardhan
Copy link
Member

/backport to release/v7.0.12

@ghost
Copy link

ghost commented Aug 11, 2022

🎉v7.0.12 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.0.x-Done Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants